Filings UI: disable local corrections

[severinbeauvais]

New description

• disable the "correct this filing" menu item for the 17 selected filings listed below (see comments)
• should we delete the local correction code or leave it unused? left in place for now
• update (or disable?) unit tests

Original description

An Annual Report local correction was successfully filed (but got stuck -- different issue):

An AGM Location Change local correction could not be filed:

A Consent Continuation Out local correction could be filed:

Here are the filings that are corrected "locally" (in Filings UI) instead of redirecting to the Edit UI correction page:

• AGM Extension
• AGM Location Change
• Amalgamation Out
• Annual Report
• Change of Address
• Change of Directors
• Change of Company Info (ie, firms)
• Change of Name
• Consent Amalgamation Out
• Consent Continuation Out
• Continuation In
• Continuation Out
• Conversion (ie, firms)
• Dissolution
• Dissolved
• Restoration
• Transition

(Staff filings cannot be corrected.)

[severinbeauvais]

Root Cause

The correction schema does not list some of the above filings as supported.

[severinbeauvais]

@NaveenHebbale @OlgaPotiagalova Can you please determine whether we should allow the correction of the missing filing types?

Filing type	Supported in schema?
AGM Extension	NO
AGM Location Change	NO
Amalgamation Out	NO
Annual Report	y
Change of Address	y
Change of Directors	y
Change of Company Info	NO
Change of Name	y
Consent Amalgamation Out	NO
Consent Continuation Out	NO
Continuation In	y
Continuation Out	NO (but y to Continued Out)
Conversion	y
Dissolution	y
Dissolved	y
Restoration	y
Transition	NO

[severinbeauvais]

Of the list in the table, above:

• should they be "local corrections" or redirect to the Edit UI correction page?
• should we simply block those corrections?

[severinbeauvais]

This ticket is blocked while awaiting the requirements.

[NaveenHebbale]

@severinbeauvais, Yesterday I discussed with @OlgaPotiagalova .For MVP we will disable correction for AR- Annual Report, AGM extension, AGM Location Change, etc .

[severinbeauvais]

When this ticket is implemented, please ensure that tickets #21672 and #21799 are closed.

[severinbeauvais]

@NaveenHebbale Should we allow a correction to a Continuation In? After all, it's similar to an Incorporation Application, Registration, or Amalgamation.

[severinbeauvais]

@NaveenHebbale Please confirm that this is correct.

In this ticket, I will disable the correction of the following filings:

• AGM Extension
• AGM Location Change
• Amalgamation Out
• Annual Report
• Change of Company Info
• Consent Amalgamation out
• Consent Continuation Out
• Continuation Out
• Conversion
• Dissolution
• Dissolved
• Restoration
• Transition

Corrections will be enabled for the following filings:

• Alteration
• Amalgamation Application
• Change of Address
• Change of Directors
• Change of Name
• Change of Registration
• Continuation In
• Correction
• Incorporation Application
• Registration
• Special Resolution disabled for now

[NaveenHebbale]

@severinbeauvais
Disabled Option - I agree
Enabled Option - I need to double-check for a Special resolution

[severinbeauvais]

Test Notes

Try some or all of these. The unit tests cover all scenarios.

[NaveenHebbale]

Closed