-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14691 COLIN states mapping to LEAR RFC #14968
14691 COLIN states mapping to LEAR RFC #14968
Conversation
c2fff9f
to
6946fa5
Compare
6946fa5
to
0e22ac4
Compare
0e22ac4
to
a225453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first thought was that the new way appears more complicated than the COLIN way. However, I really like the idea of managing "allowable transitions". When implemented, the new approach is likely to be easier to use.
16e16b7
to
f28126d
Compare
4299165
to
4c44465
Compare
4c44465
to
c8a02eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should kick this around a bit more.
rc chat threads aren't going to get us there, even though this is really close.
thanks for gathering this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still pursuing the concept of sub-state?
I don't think so. We will have things like good standing, warnings(compliance, missing business info) and other flow statuses to give us what we need. |
How will we know things like Frozen, or in various dissolution states? |
80e622d
to
10db0d2
Compare
10db0d2
to
bb73aa1
Compare
bb73aa1
to
4a69571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks workbable to me 👍
e12d811
to
fccd173
Compare
@severinbeauvais A note about the frozen flag. There is already an |
Thanks. Travis is looking into this as well (so Auth Web knows). FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem pretty close and narrowing in on smaller details.
Do we want to fully work it out, or if we're pretty close get it in to start trying it?
In a business response object, I think a "large" amount of data is OK. In a filings response object, I'd prefer to see minimum data returned, and the UI can make another call to fetch more data when the user needs it. But I don't know how this would work for the API telling us "you're allowed to correct this item" (which is business logic currently in the UI). I also don't know how the API will inform the UI whether, say, the business can be dissolved (which is more business logic in the UI)... though this flag/rule could be in the business response object. |
0864202
to
85e97d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, this captures all of our discussions, learnings from the business and pulling the design into a way we can keep valid tests and scenarios in the CI pipeline.
I like it.
Issue #: #14691
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).