Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include city and province in the company address shown in reports #463

Merged
merged 5 commits into from
May 7, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented May 7, 2024

Description

Include city and province in the company address shown in reports

Fixes # GEO-582

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New unit tests
Updated an existing end-to-end test

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@banders banders requested a review from sukanya-rath as a code owner May 7, 2024 16:32
@banders banders changed the title include city and province in the company address shown in reports feat: include city and province in the company address shown in reports May 7, 2024
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 7, 2024

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 09d6237 into main May 7, 2024
29 checks passed
@sukanya-rath sukanya-rath deleted the bug/report-address-format branch May 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants