Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase whitespace between mean and median charts #491

Merged
merged 4 commits into from
May 16, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented May 16, 2024

Description

Two CSS style classes used in the HTML report (ps-2 and pe-2) weren't defined as embedded styles within the report, so the report depended on finding definitions for these styles in the surrounding page (into which the HTML report gets injected). This worked for the HTML version of the report when viewed through the PT application, but the styles remain undefined for the PDF report. I addressed this by embedding definitions for both styles into the report.

This fixes a whitespace issue between the side-by-side "mean" and "median" charts in the application (i.e. there's now sufficient horizontal whitespace between the charts).

Also slightly widened the right margin beside the "mean" and "median" charts so that the line break within "Prefer not to say / Unknown" occurs after the slash.

Fixes # GEO-616

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Visual inspection of the HTML and PDF reports.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

…ent on style definitions in the surrounding page
…ow 'prefer not to say /' to be included all on one line.
…ow 'prefer not to say /' to be included all on one line.
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants