Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: geo 657 validate end date is always before today #513

Merged
merged 6 commits into from
May 29, 2024

Conversation

goemen
Copy link
Contributor

@goemen goemen commented May 28, 2024

Description

Validate end date is always before today

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@goemen goemen requested a review from sukanya-rath as a code owner May 28, 2024 23:59
@goemen goemen force-pushed the fix/GEO-657-validate-endtime-for-future-dates branch from 3b68ea7 to 56a4607 Compare May 29, 2024 00:03
@sukanya-rath sukanya-rath enabled auto-merge (squash) May 29, 2024 18:17
@sukanya-rath sukanya-rath merged commit 69f5876 into main May 29, 2024
31 of 36 checks passed
@sukanya-rath sukanya-rath deleted the fix/GEO-657-validate-endtime-for-future-dates branch May 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants