-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1297_NewFixtureData #969
1297_NewFixtureData #969
Conversation
7632c18
to
42620fb
Compare
@DerekRoberts @NickPhura merging this in would break the pipeline - fixtures wouldn't get loaded. I can fix the jenkinsfile to pull in the renamed fixtures, but I don't want to cause conflicts on the pipeline you're working. Should we wait on merging this into 1.44.0 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to modify jenkins to load the renamed fixtures, or the build will break.
Good plan. Let's aim for 1.44.0, when the timing isn't as close. |
@DerekRoberts @Sybrand In the jenkinsfile currently, it specifies "wellsearch.json.gz" but you don't need to specify the extensions at all (at least when running loaddata locally). You can just specify "wellsearch" and it will still scan and find the right fixture automatically. So we could update the jenkinsfile to just specify "wellsearch" and then it will work for the old zipped fixture AND the new updated unzipped fixture, depending on what fixture files exist in the branch at the time. |
@NickPhura Make that Jenkinsfile change and keep rolling! |
Pointed the Jenkinsfile to the original 'large' fixtures, for now. |
…large.json Add new registries/wellsearch fixtures with reduced data/size. Rename original aquifers.json to aquifers_large.json. Add new reduced aquifers.json with fixtures to match the reduced wellsearch.json. Rename old registries/wellsearch fixtures from <name>.json to <name>_large.json Add new registries/wellsearch fixtures with reduced data/size. Rename original aquifers.json to aquifers_large.json. Add new reduced aquifers.json with fixtures to match the reduced wellsearch.json. Temporarily use 'large' fixtures in jenkinsfile.
647bfef
to
e2b78f1
Compare
Trello Card
(Ignore my comments from scrum this morning, I realized how I was overthinking this, so its no longer an issue)
Rename old registries.json, wellsearch.json.gz, and aquifers.json fixtures to registries_large.json, wellsearch_large.json.gz, and aquifers_large.json respectively.
Add new wellsearch.json fixture with reduced data/size.
Add new registries.json fixture with reduced data/size.
Add new aquifers.json fixture with reduced data/size (To match the reduced wellsearch.json fixture).
(Not sure how well this code reviews..)