Update dev-email-worker.yml file by adding trivy scan #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbang
approved these changes
Jun 16, 2023
| @@ -11,25 +11,77 @@ on: | |||
| branches: | |||
| - main | |||
|
|
|||
| jobs: | |||
| jobs: | |||
There was a problem hiding this comment.
remove whitespace - consider installing "Fix Irregular Whitespace" plugin for you vscode.
| unit-test: | ||
| uses: SierraSystems/reusable-workflows/.github/workflows/java-unit-tests.yml@main | ||
| with: | ||
| working_directory: "src" | ||
| profile: dps-email-worker | ||
| secrets: | ||
| nexus_url: ${{ secrets.NEXUS_URL }} | ||
|
|
||
| docker build -t dev-email-worker:${{ github.sha }} . | ||
|
|
||
| #Run Vulnerability Scan usinig Trivy scanner | ||
| - name: Run Trivy vulnerability scanner for jag-icon2-common-application |
| COMPOSE_DOCKER_CLI_BUILD: 1 | ||
| DOCKER_BUILDKIT: 1 | ||
| run: | | ||
| docker build -t dev-email-worker:${{ github.sha }} . |
There was a problem hiding this comment.
I don't see a problem with using the sha, but why are you using the sha rather than just a tag? Are you planning on using a cache in the near future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app-version job has been modified and build-image job has been replaced with build-scan-image job which includes 2 more steps for trivy scan and uploading results to the Github security tab.