18495 - Add Memorandum Update to COOP Correction - Update Filer, Legal-API, Emailer

[Jxio]

Issue #: /bcgov/entity18495

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[codecov]

Codecov Report

Merging #2353 (ecc702e) into main (79511cd) will decrease coverage by 1.54%.
Report is 51 commits behind head on main.
The diff coverage is 62.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   77.37%   75.84%   -1.54%     
==========================================
  Files         202       68     -134     
  Lines       11602     3299    -8303     
  Branches     1961      534    -1427     
==========================================
- Hits         8977     2502    -6475     
+ Misses       2043      594    -1449     
+ Partials      582      203     -379     

Flag	Coverage Δ
entityemailer	70.41% <57.05%> (?)
entityfiler	80.54% <90.00%> (+0.14%)	⬆️
legalapi	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rvices/entity-emailer/src/entity_emailer/config.py	100.00% <100.00%> (ø)
...mailer/email_processors/correction_notification.py	76.41% <100.00%> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py	83.96% <100.00%> (ø)
...vices/entity-emailer/src/entity_emailer/version.py	100.00% <100.00%> (ø)
...ocessors/filing_components/rules_and_memorandum.py	89.18% <100.00%> (+0.30%)	⬆️
..._services/entity-filer/src/entity_filer/version.py	100.00% <100.00%> (ø)
...e_services/entity-filer/src/entity_filer/worker.py	71.97% <100.00%> (+0.31%)	⬆️
.../filing_processors/filing_components/correction.py	93.49% <83.33%> (-0.53%)	⬇️
...rc/entity_filer/filing_processors/agm_extension.py	89.47% <89.47%> (ø)
...iler/email_processors/special_resolution_helper.py	69.64% <0.00%> (ø)
... and 4 more

... and 178 files with indirect coverage changes

[seeker25]

Looks good to me, do the outputs list need to change now to accommodate the fact someone uploaded a memorandum?

EG - changes here:

https://github.com/bcgov/lear/blob/75c7c6f925775e24a13679f429903e477c8ebfbf/legal-api/src/legal_api/reports/report.py#L999C10-L999C10

lear/legal-api/src/legal_api/core/meta/filing.py

Line 571 in 75c7c6f

if filing.meta_data.get('correction', {}).get('uploadNewRules'):

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Jxio]

After confirm with Karim, the legal-api unit tests have 3 failed cases for a while, not from this PR

[argush3]

After confirm with Karim, the legal-api unit tests have 3 failed cases for a while, not from this PR

yeah, we'll be fixing these broken tests in #18954