Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20992 - Create skeleton involuntary dissolutions job #2622

Merged
merged 10 commits into from
May 1, 2024

Conversation

chenhongjing
Copy link
Collaborator

@chenhongjing chenhongjing commented Apr 29, 2024

Issue #: /bcgov/entity#20992

Description of changes:

  • Create skeleton involuntary dissolutions job
  • Add CI/CD workflow files for involuntary dissolutions job

Things verified

  • Job runs at local docker

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Copy link
Contributor

@tshyun24 tshyun24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing my last approval😭

@argush3
Copy link
Collaborator

argush3 commented Apr 30, 2024

As per our conversation, please setup testing so we can add unit tests as we build out this job.

Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Copy link

gitguardian bot commented May 1, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9442085 Triggered Generic Password f606d72 .github/workflows/involuntary-dissolutions-ci.yml View secret
9442085 Triggered Generic Password f606d72 .github/workflows/involuntary-dissolutions-ci.yml View secret
9442085 Triggered Generic Password a2d4f57 .github/workflows/involuntary-dissolutions-ci.yml View secret
9442085 Triggered Generic Password 40a8b58 .github/workflows/involuntary-dissolutions-ci.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
7.2% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@chenhongjing chenhongjing merged commit 5f77d7a into bcgov:main May 1, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants