Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20340 Close decision dropdowns when an option is selected #1446

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

semmatti
Copy link
Contributor

Issue #:
bcgov/entity#20340

Description of changes:
This PR automatically closes ListSelect components with the multiple prop passed in when an option is selected/deselected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@semmatti
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1446-s9kwnh12.web.app

Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmatti semmatti merged commit 152b2f0 into bcgov:main Apr 10, 2024
4 of 5 checks passed
rarmitag pushed a commit to rarmitag/name-examination that referenced this pull request Apr 11, 2024
* close `ListSelect` with `multiple` prop when an option is selected/deselected

* update version

* add prop to toggle behaviour

* consistent prop placement

* trigger pipline

* trigger pipline 2
rarmitag added a commit that referenced this pull request Apr 11, 2024
* Update spacing in examine.vue

* 20340 Close decision dropdowns when an option is selected (#1446)

* close `ListSelect` with `multiple` prop when an option is selected/deselected

* update version

* add prop to toggle behaviour

* consistent prop placement

* trigger pipline

* trigger pipline 2

* Update pages/Examine.vue

Co-authored-by: semmatti <144159881+semmatti@users.noreply.github.com>

---------

Co-authored-by: semmatti <144159881+semmatti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants