Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offset field #55

Merged
merged 2 commits into from Jan 31, 2022
Merged

fix: offset field #55

merged 2 commits into from Jan 31, 2022

Conversation

mbystedt
Copy link
Collaborator

No description provided.

@mbystedt
Copy link
Collaborator Author

offset isn't a ECS field. ECS has no log offset or line number field but log.file.offset seems alright to me.

DerekRoberts
DerekRoberts previously approved these changes Jan 14, 2022
View reviewed changes
@mbystedt mbystedt merged commit 549dcaf into main Jan 31, 2022
@mbystedt mbystedt deleted the fix/offsetField branch January 31, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gormless87 gormless87 gormless87 approved these changes

@DerekRoberts DerekRoberts DerekRoberts left review comments

@andrwils andrwils Awaiting requested review from andrwils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbystedt @DerekRoberts @gormless87