feat: update code to use webflux #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoMarchiEncora
requested review from
paulushcgcj and
mamartinezmejia
as code owners
paulushcgcj
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Looks good. Just for documentation, we will remove the code duplication and put it as part of nr-forest-client-commons
|
Your Pull Request code is being promoted! Please follow the link below. |
paulushcgcj
pushed a commit
that referenced
this pull request
Jan 31, 2023
Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
1 task
mamartinezmejia
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Improved tests and fixed issue with querydsl * ci: adding vault broker api * ci: addressing inconsistencies * ci: testing action * ci: changing intention file location * ci: narrowing down build error * ci: readding intention open * ci: fixing curl url * ci: fixing curl url * ci: adding back broker code * ci: adding back broker code * ci: fixing broker url * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: testing vault broker * ci: completing vault login using broker * ci: fixing unwrap api * ci: fixing unwrap api * ci: fixing unwrap api * feat: update code to use webflux (#95) Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * ci: updating broker action * ci: updating broker action * ci: updating broker action --------- Co-authored-by: brunoMarchiEncora <bruno.marchi@encora.com> Co-authored-by: brunoMarchiEncora <117365587+brunoMarchiEncora@users.noreply.github.com>
This was referenced Feb 1, 2023
Merged
This was referenced Feb 3, 2023
This was referenced Feb 10, 2023
This was referenced Feb 22, 2023
This was referenced Mar 6, 2023
Merged
This was referenced Mar 13, 2023
Merged
Merged
This was referenced Mar 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the code to use reactive library (webflux)
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Type of change
How Has This Been Tested?
Checklist
Thanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow