-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1052 incorporate axios with admin api #1067
Merged
ianliuwk1019
merged 15 commits into
main
from
feat/1052-incorporate-axios-with-admin-api
Dec 7, 2023
Merged
feat: #1052 incorporate axios with admin api #1067
ianliuwk1019
merged 15 commits into
main
from
feat/1052-incorporate-axios-with-admin-api
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bit on instantiation.
frontend/src/components/managePermissions/ManagePermissions.vue
Outdated
Show resolved
Hide resolved
[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed! |
MCatherine1994
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fam_admin_management_api_base_url
value intoenv.json
for local admin api server url.baseURL
, fromdefaultAxiosConfig
so that baseURL can be conditionally added laterfor different api(s).
AdminMgmtApiBaseUrl
toEnvironmentSettings.ts
and refactor.appAccessControlApiService
andadminManagementApiService
and providegetters for these two groups of services.
provide
to provide services.apiService
toManagePermission.vue
andGrantAccess.vue
.