Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1052 incorporate axios with admin api #1067

Merged
merged 15 commits into from
Dec 7, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Dec 5, 2023

  • Add fam_admin_management_api_base_url value into env.json for local admin api server url.
  • Remove baseURL, from defaultAxiosConfig so that baseURL can be conditionally added later
    for different api(s).
  • Add new AdminMgmtApiBaseUrl to EnvironmentSettings.ts and refactor.
  • Define a SERVICE_KEY for ApiServiceFactory for dependency injection.
  • Group services into appAccessControlApiService and adminManagementApiService and provide
    getters for these two groups of services.
  • Add generic createInstance to instantiate Axios api(s) in ApiServiceFactory.
  • At main.ts, use Vue provide to provide services.
  • Inject apiService to ManagePermission.vue and GrantAccess.vue.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review December 5, 2023 23:16
@MCatherine1994
Copy link
Collaborator

MCatherine1994 commented Dec 6, 2023

this looks good to me from the testing perspective, I tried a way to mock the inject and the tests pass

Screen Shot 2023-12-06 at 12 18 30 PM Screen Shot 2023-12-06 at 12 18 44 PM

Copy link

sonarcloud bot commented Dec 7, 2023

[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianliuwk1019 ianliuwk1019 merged commit 0b0cc70 into main Dec 7, 2023
10 of 11 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1052-incorporate-axios-with-admin-api branch December 7, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants