-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #970 add tests for adding forest client number #1102
feat: #970 add tests for adding forest client number #1102
Conversation
e3d9321
to
5a417d1
Compare
Hi @NickSaglioni , could you also add a minor update on frontend readme about what types of tests we currently do, what tools we use, and how to run test locally? Thank you. |
Sure, I'll do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NickSaglioni , I have add some comments, hope not too much for you to tackle .
Since this is probably the first frontend test file, there are many tests to be done here on this component. I appreciate you spent time on this to set some common examples for later test writing.
Looks pretty good overall, just some small things left, almost there! thanks so much Nick and Ian!!! |
|
ForestClientInput
component;ForestClientCard
component;LoadingState
to have getter and setter for the loading state;