Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #970 add tests for adding forest client number #1102

Merged

Conversation

NickSaglioni
Copy link
Contributor

  • Adding tests for the ForestClientInput component;
  • Adding tests for the ForestClientCard component;
  • Refactoring LoadingState to have getter and setter for the loading state;

@NickSaglioni NickSaglioni force-pushed the feat/970-tests-for-adding-multiple-forest-client-numbers branch from e3d9321 to 5a417d1 Compare December 21, 2023 17:08
@ianliuwk1019
Copy link
Collaborator

Hi @NickSaglioni , could you also add a minor update on frontend readme about what types of tests we currently do, what tools we use, and how to run test locally? Thank you.

@NickSaglioni
Copy link
Contributor Author

Hi @NickSaglioni , could you also add a minor update on frontend readme about what types of tests we currently do, what tools we use, and how to run test locally? Thank you.

Sure, I'll do that.

@ianliuwk1019
Copy link
Collaborator

Hi Nick, I am not sure what this comment means, maybe its left over from the past.
Could you check and cleanup if not making sense.
Thank you.
image

@ianliuwk1019
Copy link
Collaborator

Hi Nick, a bit confusing on this part, should be simple, could you check?
Is this logic unnecessary? The previous expect already make sure it has a emitted property, right?
image

Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NickSaglioni , I have add some comments, hope not too much for you to tackle .
Since this is probably the first frontend test file, there are many tests to be done here on this component. I appreciate you spent time on this to set some common examples for later test writing.

frontend/src/services/http/HttpCommon.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientCard.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientCard.spec.ts Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
frontend/src/tests/ForestClientCard.spec.ts Show resolved Hide resolved
frontend/src/tests/ForestClientInput.spec.ts Outdated Show resolved Hide resolved
@MCatherine1994
Copy link
Collaborator

Looks pretty good overall, just some small things left, almost there! thanks so much Nick and Ian!!!

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@NickSaglioni NickSaglioni merged commit 4a2bca0 into main Jan 3, 2024
10 checks passed
@NickSaglioni NickSaglioni deleted the feat/970-tests-for-adding-multiple-forest-client-numbers branch January 3, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants