Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #972 axios version upgrade #1125

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Jan 16, 2024

  • After investigation, for now there is no option to specify "axios" version during api-client code generation using openapitools/openapi-generator with typescript-axios. So we upgrade axios version manually on "frontend", "client-code-gen\gen\admin-management-api" and "client-code-gen\gen\app-access-control-api".
  • Bump "axios" version up from version 0.26.1 to 1.6.5.
  • Fixed affected code due to "axios" major version upgrade (However, the type for "AxiosRequestConfig" needs to be changed to InternalAxiosRequestConfig. This is a bit strange to me by the name but is needed based on library).
  • Update client-code-gen readme.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review January 16, 2024 21:41
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ianliuwk1019 ianliuwk1019 merged commit 986718b into main Jan 17, 2024
10 checks passed
@ianliuwk1019 ianliuwk1019 deleted the fix/972-axios-version-upgrade branch January 17, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants