Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: line up node versions (18 vs 20) #51

Closed
DerekRoberts opened this issue Aug 28, 2023 · 0 comments · Fixed by #52
Closed

feat: line up node versions (18 vs 20) #51

DerekRoberts opened this issue Aug 28, 2023 · 0 comments · Fixed by #52
Assignees
@DerekRoberts
Labels
enhancement New feature or request

Comments

@DerekRoberts
Copy link
Member

Docker build is using node 20, while this app was using types for node 16. Dep PR #36 bring types up to 18.

Node should be consistently lined up, including switching to a more obvious base, which node:alpine3.17 doesn't make versions clear.
@DerekRoberts DerekRoberts added the enhancement New feature or request label Aug 28, 2023
@DerekRoberts DerekRoberts self-assigned this Aug 28, 2023
@DerekRoberts DerekRoberts linked a pull request Aug 28, 2023 that will close this issue
feat: line up node versions #52
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: line up node versions bcgov/nr-silva
1 participant
@DerekRoberts