Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: line up node versions #52

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: line up node versions #52

merged 3 commits into from
Aug 28, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 28, 2023

Node versions inconsistent. See issue.

UPDATE: Bonus! v18 in our test action solved a failing test. :D


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts self-assigned this Aug 28, 2023
@DerekRoberts DerekRoberts added bug Something isn't working enhancement New feature or request labels Aug 28, 2023
This was linked to issues Aug 28, 2023
Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts merged commit c8fcf68 into main Aug 28, 2023
5 of 6 checks passed
@DerekRoberts DerekRoberts deleted the bug/silenceFailingTests branch August 28, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: line up node versions (18 vs 20) bug: failing test(s)
2 participants