Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/746 change wording in error messages #747

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Jan 9, 2024

Description

Closes #746 #734

Changelog

New

  • None

Changed

  • Changed error message wording described in the two issues.

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend
Backend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@craigyu craigyu added the front-end front-end related task label Jan 9, 2024
@craigyu craigyu self-assigned this Jan 9, 2024
@craigyu craigyu linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, small PR. So easy even I can handle it! ;)

Copy link
Contributor

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@craigyu craigyu merged commit 303f785 into main Jan 9, 2024
16 of 17 checks passed
@craigyu craigyu deleted the fix/746-change-wording-in-error-messages branch January 9, 2024 23:41
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
* fix: should be to must be

* fix: err msg

* fix: change function call
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: should be to must be

* fix: err msg

* fix: change function call
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: should be to must be

* fix: err msg

* fix: change function call
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: should be to must be

* fix: err msg

* fix: change function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change wording in error messages Update rules for SMP success
4 participants