Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/614 sticky toolbar and header #790

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Jan 19, 2024

Description

Closes #614

There's a defect when users scroll to the bottom, I tried to fix it but I can't justify the time spent on this anymore, I think we can look pass this 🫣
image

Changelog

New

  • sticky toolbar and header

Changed

  • styles for the related components

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend
Backend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@craigyu craigyu self-assigned this Jan 19, 2024
@craigyu craigyu added the front-end front-end related task label Jan 19, 2024
Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Simple and clean.

Quick question: shouldn't we let the user see the table title? Note in the screenshot, there's no title, unless the user scrolls up.
image

cc: @mmarsoleta @kevinginley

@mmarsoleta
Copy link

Very nice! Simple and clean.

Quick question: shouldn't we let the user see the table title? Note in the screenshot, there's no title, unless the user scrolls up. image

cc: @mmarsoleta @kevinginley

Yes, I believe that the table's header should be fixed as well. (everything above the columns title row should be sticky). Thank you for asking. Good job on making this table sticky, thx! 🤗

image

Copy link
Contributor

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the new changes, LGTM!

@craigyu
Copy link
Collaborator Author

craigyu commented Jan 24, 2024

image

@mgaseta @RMCampos done :)

Copy link
Contributor

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm! Good job!

@craigyu craigyu enabled auto-merge (squash) January 26, 2024 04:27
@craigyu craigyu merged commit fdbea95 into main Jan 26, 2024
17 checks passed
@craigyu craigyu deleted the feat/614-header-and-toolbar-style-changes branch January 26, 2024 04:36
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
* feat: sticky toolbar and header

* feat: make table context sticky
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* feat: sticky toolbar and header

* feat: make table context sticky
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* feat: sticky toolbar and header

* feat: make table context sticky
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* feat: sticky toolbar and header

* feat: make table context sticky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header and Toolbar style changes
4 participants