-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/614 sticky toolbar and header #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the new changes, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working like a charm! Good job!
* feat: sticky toolbar and header * feat: make table context sticky
* feat: sticky toolbar and header * feat: make table context sticky
* feat: sticky toolbar and header * feat: make table context sticky
* feat: sticky toolbar and header * feat: make table context sticky
Description
Closes #614
There's a defect when users scroll to the bottom, I tried to fix it but I can't justify the time spent on this anymore, I think we can look pass this 🫣
![image](https://private-user-images.githubusercontent.com/25162561/298176819-3ff8a02b-19cf-40de-8df0-6a063b17d1d1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxNzg2NDYsIm5iZiI6MTcyMjE3ODM0NiwicGF0aCI6Ii8yNTE2MjU2MS8yOTgxNzY4MTktM2ZmOGEwMmItMTljZi00MGRlLThkZjAtNmEwNjNiMTdkMWQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE0NTIyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM2YWUxMmVkNDg2NDM5NDlhMzk0Yjc1MjRiODU2OTVkOTU1ZDk5NjMyOTllYTMxNGU3NDlhMDQ0OTg2OWEyNmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sMM9ruSDgYgLjJJkDcnbEfJPLyZoKhgpA6IJZXljFRc)
Changelog
New
Changed
Removed
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Frontend
Backend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow