Merge pull request #72 from bcgov/contact-change-emails

var for admins emails array for public and private, contact list chan…
bcgov · Aug 30, 2023 · a5844e3 · a5844e3
2 parents e6b568b + 42ac297
commit a5844e3
Show file tree

Hide file tree

Showing 7 changed files with 334 additions and 26 deletions.
diff --git a/src/ches/emailConstants.js b/src/ches/emailConstants.js
@@ -1,5 +1,5 @@
-export const adminEmails = ["faisal.hamood@gov.bc.ca", "jason.leach@fullboar.ca", "oamar.kanji@gov.bc.ca"];
-export const adminPublicEmails = [];
+export const adminEmails = `${process.env.PRIVATE_ADMIN_EMAILS}`.split(',')
+export const adminPublicEmails = `${process.env.PUBLIC_ADMIN_EMAILS}`.split(',')
 
 export const ministriesNames = [
   {

diff --git a/src/ches/emailHandlersPublic.ts b/src/ches/emailHandlersPublic.ts
@@ -117,7 +117,6 @@ export const sendProvisionedEmails = async (request) => {
 
 
 export const sendEditRequestEmails = async (editRequest) => {
-
   try {
     await chesService.send({
       bodyType: "html",
@@ -142,7 +141,6 @@ export const sendEditRequestEmails = async (editRequest) => {
   } catch (error) {
     console.error(error);
   }
-  // *** What about no quota change and no contact change?
 };
 
 export const sendRejectEmail = async (request) => {

diff --git a/src/ches/emailHelpers.ts b/src/ches/emailHelpers.ts
@@ -47,7 +47,7 @@ export const generateEmailTemplatePrivateData = (
         : { ...incomingProject };
 
     const secondaryTechnicalLead =
-        (!!project.secondaryTechnicalLead || !!requestedProject.secondaryTechnicalLead) && requestedProject.secondaryTechnicalLead.id !== project.secondaryTechnicalLead.id
+        (!!project.secondaryTechnicalLead || !!requestedProject.secondaryTechnicalLead) && requestedProject.secondaryTechnicalLead?.id !== project.secondaryTechnicalLead?.id
             ? project.secondaryTechnicalLead : !!requestedProject.secondaryTechnicalLead ? requestedProject.secondaryTechnicalLead : null;
     const primaryTechnicalLead = project.primaryTechnicalLead;
     const projectOwner = project.projectOwner;
@@ -241,10 +241,9 @@ export const generateEmailTemplatePublicData = (
         : { ...incomingProject };
 
 
-    const secondaryTechnicalLead =
-        (!!project.secondaryTechnicalLead || !!requestedProject.secondaryTechnicalLead) && requestedProject.secondaryTechnicalLead.id !== project.secondaryTechnicalLead.id
-            ? project.secondaryTechnicalLead : !!requestedProject.secondaryTechnicalLead ? requestedProject.secondaryTechnicalLead : null;
-    const primaryTechnicalLead = project.primaryTechnicalLead;
+        const secondaryTechnicalLead = (!!project.secondaryTechnicalLead || !!requestedProject.secondaryTechnicalLead) && requestedProject.secondaryTechnicalLead?.id !== project.secondaryTechnicalLead?.id
+        ? project.secondaryTechnicalLead : !!requestedProject.secondaryTechnicalLead ? requestedProject.secondaryTechnicalLead : null;
+     const primaryTechnicalLead = project.primaryTechnicalLead;
     const projectOwner = project.projectOwner;
 
 
@@ -281,6 +280,12 @@ export const generateEmailTemplatePublicData = (
         BudgetProdReq: project.budget.prod,
         BudgetToolsReq: project.budget.tools,
         AccountCodingReq: project.accountCoding.replace(/(.{3})(.{5})(.{5})(.{4})(.{7})/g, "$1 $2 $3 $4 $5"),
+        isPOChanged: requestedProject.projectOwner.email !== project.projectOwner.email,        
+        POReq: requestedProject.projectOwner.email,
+        isPrimeTLChanged:requestedProject.primaryTechnicalLead.email!== project.primaryTechnicalLead.email,
+        PrimeTLReq:requestedProject.primaryTechnicalLead.email,
+        isSecTLChanged:requestedProject.secondaryTechnicalLead?requestedProject.secondaryTechnicalLead.email!== project.secondaryTechnicalLead.email:undefined,
+        SecTLReq:requestedProject.secondaryTechnicalLead?requestedProject.secondaryTechnicalLead.email:null,
         ...other,
     };
 };