User Access + Global Address Fixes #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1686-ne5p4br3.web.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#16952
/bcgov/entity#17647
/bcgov/entity#17463
Description of changes:
Misc UXA fixes for Home Location and QS Information view
Correct default values for address country and regions to v-selects thinking there was a selected value.
The above is a vuetify issue (or feature if you ask them) that allows empty strings to present as a legit value.
[Bug Report][3.0.6] VSelect (and VAutoComplete) treats an empty string as non empty value vuetifyjs/vuetify#16372
Includes authHandler in app.vue to verify the CURRENT_ACCOUNT is set before initializing the application, prevent any timing issues where auth is slower than app initialization.
Minor update to transfer type selector to prevent missed event firings on selection
Modify CivicAddress to take it's schema as a prop, for reuse.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).