Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting ChooseAuthMethodView.vue back to 40c053cc5482b2e485132f9593dc… #2128

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

seeker25
Copy link
Collaborator

…851e39567023

Reverting layout.scss.

Revert PR 2127, 2123.

Description of changes:
As per requested by the business.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Reverting layout.scss.

Revert PR 2127, 2123.
@seeker25 seeker25 self-assigned this Oct 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 changed the title Putting ChooseAuthMethodView.vue back to 40c053cc5482b2e485132f9593dc… Reverting ChooseAuthMethodView.vue back to 40c053cc5482b2e485132f9593dc… Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2128 (1b3c028) into main (049628e) will decrease coverage by 33.61%.
The diff coverage is 91.30%.

❗ Current head 1b3c028 differs from pull request most recent head a370220. Consider uploading reports for the commit a370220 to get more accurate results

@@             Coverage Diff             @@
##             main    #2128       +/-   ##
===========================================
- Coverage   78.67%   45.05%   -33.62%     
===========================================
  Files         268      115      -153     
  Lines        9776     2457     -7319     
  Branches      516      322      -194     
===========================================
- Hits         7691     1107     -6584     
+ Misses       2085     1350      -735     
Flag Coverage Δ
activityloglistenerqueue ?
authapi ?
authweb 45.05% <91.30%> (+0.57%) ⬆️
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...auth/account-settings/account-info/AccountInfo.vue 58.33% <ø> (ø)
...s/auth/account-settings/product/ProductPackage.vue 63.63% <ø> (ø)
...nts/auth/account-settings/statement/Statements.vue 100.00% <ø> (ø)
...auth/account-settings/transaction/Transactions.vue 100.00% <ø> (ø)
auth-web/src/components/auth/common/Product.vue 83.33% <ø> (ø)
...nents/auth/create-account/AccountCreatePremium.vue 16.66% <0.00%> (ø)
...b/src/components/auth/create-account/BcolLogin.vue 50.00% <ø> (ø)
...mponents/auth/manage-business/EntityManagement.vue 33.33% <ø> (+8.33%) ⬆️
auth-web/src/components/auth/staff/PPRLauncher.vue 100.00% <ø> (ø)
...ff/account-management/StaffActiveAccountsTable.vue 66.66% <ø> (ø)
... and 171 more

@thorwolpert thorwolpert merged commit f6d4b0e into main Oct 26, 2022
@seeker25
Copy link
Collaborator Author

seeker25 commented Oct 26, 2022

We'll merge this back inwhen John gives us the go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants