feat: #tno-2100 - show checkboxes for advanced search #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylgarmor
commented
Jan 18, 2024
kylgarmor
commented
- created check box display for all sections that previously display select boxes
- added ability to swap between check box and select
- select between checkbox and select is stored in a cookie
- update tno core to 0.1.16
- first pass on media types
- added ability to swp between check box and select
- update tno core to 0.1.16
kylgarmor
added
enhancement
Fosol
reviewed
Jan 18, 2024
...ber/src/features/search-page/components/advanced-search/components/sections/MediaSection.tsx
Outdated
Show resolved
Hide resolved
| Deselect All | ||
| </Button> | ||
| </div> | ||
| {seriesOptions.map((item, index) => ( |
There was a problem hiding this comment.
Just a note regarding using index for they key in many of your implementations. This is generally not a reliable key and should only be used when it's the only option. However, there are safe use-cases for it. I don't know whether these are safe or not.
- fixed key issue - removed commented out code
- fixed key issue - removed commented out code
Fosol
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.