Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable reservation view #645

Closed
esune opened this issue Jun 6, 2023 · 6 comments
Closed

Configurable reservation view #645

esune opened this issue Jun 6, 2023 · 6 comments
Assignees

Comments

@esune
Copy link
Member

esune commented Jun 6, 2023

Acceptance Criteria:

  • The form in the reservations view is configurable: the required fields can be configured for each instance
  • The required fields (email, tenant name) are always required
  • Data structure in backend is JSON blob, not individual columns
  • Innkeeper view should account for unpredictable length in data when displaying it
  • Keep it as simple and light as possible, no unnecessary dependencies or additional services
@esune esune closed this as completed Jun 6, 2023
@esune esune reopened this Jun 6, 2023
@loneil
Copy link
Collaborator

loneil commented Jun 6, 2023

Will need to consider where the "form schema" (IE the customization of what the reservation form should be) is kept.
Easiest is probably just Tenant UI configuration (with the other env vars). Alternatively could be in the persistence layer of the Innkeeper plugin with an endpoint to get/update it, etc.

So not add any database to the Tenant UI itself as part of this ticket or anything.

@esune
Copy link
Member Author

esune commented Jun 7, 2023

@loneil agreed.

In the past I used Angular Formly which allows for a JSON template to be specified and loaded at runtime. Similarly, SurveyJS was used in issuer-kit to allow forms to be dynamically rendered at runtime.

Somrthing similar to this would probably be ideal, as it allows for a template to be defined and injected in the Tenant UI and the data to be stored as a JSON blob in the current database (that will likely require some "massaging").

@hiteshgh hiteshgh assigned popkinj and unassigned amanji Aug 10, 2023
@hiteshgh
Copy link

Assigned @popkinj

@loneil
Copy link
Collaborator

loneil commented Aug 22, 2023

Added block on this ticket for #773

cc @popkinj @esune @hiteshgh

Not sure if 'block' is appropriate, but noting this can't really merge in without accounting for backend (and merging in is probably Definition of Done for tickets)

@hiteshgh
Copy link

hiteshgh commented Sep 7, 2023

unblocked

@esune
Copy link
Member Author

esune commented Sep 14, 2023

Resolved by #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants