Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OIDC provider for Tenant UI #176

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Dec 15, 2023

Update OIDC provider so we can deprecate the digitaltrust-nrm realm.

This doesn't need to coincide with any release or any other planning, we could just deploy these values at any time. The new digitaltrust-citz realm is already set up with the required client and things.

Signed-off-by: Lucas <lucasoneil@gmail.com>
@loneil loneil requested review from i5okie and esune December 15, 2023 22:09
Signed-off-by: Lucas <lucasoneil@gmail.com>
Signed-off-by: Lucas <lucasoneil@gmail.com>
WadeBarnes
WadeBarnes previously approved these changes Dec 18, 2023
esune
esune previously approved these changes Dec 18, 2023
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Want to get the changes deployed before we merge?

@loneil
Copy link
Contributor Author

loneil commented Dec 18, 2023

Looks good! Want to get the changes deployed before we merge?

Yeah not sure what the order of operations for sandbox, test, and prod are still?
Would a new helm release number be needed? Or is it just doing a deploy from this branch and then merging.

As well for Sandbox can we deploy a values change without doing the environment reset.

Signed-off-by: Lucas <lucasoneil@gmail.com>
@loneil loneil dismissed stale reviews from esune and WadeBarnes via de0ab18 December 18, 2023 18:45
@esune
Copy link
Member

esune commented Dec 18, 2023

We can just run a helm upgrade using these values files, no new release needed as these values are overlayed on top of the defaults anyway. I would not worry about Sandbox since we really don't use the Innkeeper functionality there, we can likely just let it self-update next time the environment is reset.

@loneil
Copy link
Contributor Author

loneil commented Dec 18, 2023

Sure, yeah then it could go to test and prod with the vals from this PR any time.

@loneil
Copy link
Contributor Author

loneil commented Dec 20, 2023

Deployed up through all environments from these values files

@loneil loneil merged commit 743bc03 into bcgov:main Dec 21, 2023
@loneil loneil deleted the chore/updateKcRealms branch December 21, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants