Added comment on unchecking Docker Compose V2 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WadeBarnes
requested changes
Jan 24, 2022
satishsurath
added a commit
to satishsurath/von-network
that referenced
this pull request
Jan 24, 2022
Feedbacl based on bcgov#191 (review) Co-authored-by: Wade Barnes <wade@neoterictech.ca>
|
Closing and resubmitting the pull request based on comments from @WadeBarnes |
satishsurath
commented
Jan 24, 2022
satishsurath
added a commit
to satishsurath/von-network
that referenced
this pull request
Jan 24, 2022
Feedbacl based on bcgov#191 (review) Co-authored-by: Wade Barnes <wade@neoterictech.ca> Signed-off-by: Satish Surath <s@n-m.co>
WadeBarnes
reviewed
Jan 24, 2022
README.md
Outdated
| @@ -48,6 +50,7 @@ The [tutorial about using VON Network](docs/UsingVONNetwork.md) has information | |||
|
|
|||
| ## Running the web server in Docker against another ledger | |||
|
|
|||
| Note that in order to use Docker Desktop (> version 3.4.0), make sure you uncheck the "Use Docker Compose V2" in Docker Desktop > Preferences > General. Refer to this issue for additional details; [#170](https://github.com/bcgov/von-network/issues/170#issuecomment-972898014) | |||
There was a problem hiding this comment.
@nomadic-me, did you mean to leave the note down here as well. I'm not sure it needs to be in both places.
There was a problem hiding this comment.
I had initially added it in both places;
but based on your comment - it makes sense to remove the duplicate from the section "Running the web server in Docker against another ledger"
satishsurath
commented
Jan 24, 2022
…ker to run von-network Signed-off-by: Satish Surath <s@n-m.co>
WadeBarnes
approved these changes
Jan 24, 2022
|
@nomadic-me, I squashed the commits to clean up the history. You may need to reset your local branch to match your remote as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a temporary workaround for the issue #170