Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save RDPS to S3 for SFMS #3741

Closed
wants to merge 16 commits into from
Closed

Save RDPS to S3 for SFMS #3741

wants to merge 16 commits into from

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Jun 18, 2024

@dgboss dgboss changed the title Task/rdps save/3663 Save RDPS to S3 for SFMS Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 43.24324% with 105 lines in your changes missing coverage. Please review.

Project coverage is 79.68%. Comparing base (cbf9bdb) to head (7b1c4f4).

Files Patch % Lines
api/app/jobs/rdps_sfms.py 0.00% 104 Missing ⚠️
api/app/jobs/env_canada_utils.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3741      +/-   ##
==========================================
- Coverage   80.42%   79.68%   -0.75%     
==========================================
  Files         293      295       +2     
  Lines       10583    10709     +126     
  Branches      525      525              
==========================================
+ Hits         8511     8533      +22     
- Misses       1927     2031     +104     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few minor comments and we can discuss the storing of s3 keys later

api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 19, 2024

@dgboss dgboss closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants