Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy_ems_data: currently standardizes 'Alkalinity pH 4.5/4.2' to 'pH' #72

Closed
HeatherGranger opened this issue Mar 28, 2017 · 4 comments
Closed

Tidy_ems_data: currently standardizes 'Alkalinity pH 4.5/4.2' to 'pH' #72

HeatherGranger opened this issue Mar 28, 2017 · 4 comments
Assignees
@ateucher
Labels
bug

Comments

@HeatherGranger
Copy link
Collaborator

When tidy_ems_data is run, it changes the parameter 'Alkalinity pH 4.5/4.2' to 'pH.
Parameter code is D102.
@ateucher ateucher added the bug label Mar 28, 2017
@ateucher ateucher self-assigned this Mar 28, 2017
@ateucher
Copy link
Contributor

@HeatherGranger do you mean standardize_wqdata? tidy_ems_data shouldn't mess with parameter names...

@HeatherGranger
Copy link
Collaborator Author

ah yes, I mean standardize_wqdata

@ateucher
Copy link
Contributor

Gotcha. Can you paste some code that will reproduce the error?

ateucher added a commit that referenced this issue Mar 30, 2017
@ateucher
Smarter matching in wqbc_subsitute
077ac07 
Get exact matches first, then only do word-by-word lookup matching on those that had no exact match. #72
ateucher added a commit that referenced this issue Mar 30, 2017
@ateucher
Add a test for new substitute fix. #72
a4ccaff
@ateucher
Copy link
Contributor

@HeatherGranger this should be fixed now. Let me know if it persists or other wonky things happen with standardize_wqdata as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ateucher ateucher

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ateucher @HeatherGranger