Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy_ems_data should retain more columns #83

Closed
stephhazlitt opened this issue Jul 5, 2017 · 2 comments
Closed

tidy_ems_data should retain more columns #83

stephhazlitt opened this issue Jul 5, 2017 · 2 comments
Labels
documentation enhancement

Comments

@stephhazlitt
Copy link
Member

Add SAMPLE_STATE and SAMPLE_DESCRIPTOR to default set of columns that are retained, and add an argument retain_cols where a user can pass a character vector of additional column names to retain.
@stephhazlitt stephhazlitt mentioned this issue Jul 5, 2017
Closed
@ateucher
Copy link
Contributor

Also document the default columns that are retained

@KaPrz
Copy link

KaPrz commented Mar 7, 2018

Also please include SAMPLE_CLASS column as this indicates whether it is a regular sample, replicate, or blank

ateucher added a commit that referenced this issue Mar 7, 2018
@ateucher
Tests for column names in tidy_ems_data (#83)
5f61110
ateucher added a commit that referenced this issue Mar 7, 2018
@ateucher
Add three additional columns to default EMS columns retained. Document.
ee93d28 
Fixes #83
@ateucher ateucher mentioned this issue Mar 7, 2018
Merged
ateucher added a commit that referenced this issue Mar 7, 2018
@ateucher
Merge pull request #94 from bcgov/develop
95d44c9 
Develop. Closes #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ateucher @stephhazlitt @KaPrz