Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blank replicates should be removed early on, especially when calculating averages across replicates #90

Closed
ateucher opened this issue Jan 12, 2018 · 2 comments
Closed

blank replicates should be removed early on, especially when calculating averages across replicates #90

ateucher opened this issue Jan 12, 2018 · 2 comments
Labels
bug

Comments

@ateucher
Copy link
Contributor

ateucher commented Jan 12, 2018 •
edited

Column is called SAMPLE_CLASS, blank is denoted by Blank - field, Blank - equipment, etc.
@ateucher ateucher added the bug label Jan 12, 2018
@ateucher ateucher changed the title blanks should be removed early on, especially when calculating averages across replicates blank replicates should be removed early on, especially when calculating averages across replicates Jan 12, 2018
@ateucher
Copy link
Contributor Author

Though it might be helpful to keep them for visualization?

@ateucher
Copy link
Contributor Author

ateucher commented Mar 19, 2018 •
edited

This is now controlled by the remove_blanks argument in clean_wq_data(). Default is FALSE to not break existing behaviour. If it's set to TRUE it requires a SAMPLE_CLASS object in the data frame and removes any records that start with "[Bb]lank"

ateucher added a commit that referenced this issue Mar 19, 2018
@ateucher
Merge pull request #97 from bcgov/develop
549ff8c 
Argument remove_blanks in clean_wq_data. Fixes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ateucher