-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IE 8/9? #22
Comments
Hey @ahmadux, slidr.js should already support IE8/9. It's given me no errors when I've been testing it on IE10 running IE8/IE9 browser mode. Could you provide some sort of screenshot to the issues you're experiencing, and the IE version(s) that you're using? |
Hey B, Attaching three screenshots of the issue I am facing. ErrorDesc: Shows what the error message is. ScriptLocation: Shows the line location of the error and that it is the slidr.js file with the issue. watchVariables: Shows the value of the variables. They seem to be ok but I dunno. It works beautifully in IE 10 and all the other browsers. IE 8 seems to have something up it's a**. Lemme know what you think. Regards, Usman Ahmad Date: Mon, 10 Feb 2014 01:32:10 -0800 Hey @ahmadux, slidr.js should already support for IE8/9. It's given me no errors when I've been testing it on IE10 running IE8/IE9 browser mode. Could you provide some sort of screenshot to the issues you're experiencing, and the IE version(s) that you're using? — |
Hey @ahmadux, Did you forget to attach the screenshots? I'm not seeing anything. |
Hey @ahmadux, Looks like you're running an IE version that's different than the browser compatibility mode packaged with IE10. Nonetheless, I've pushed a devel build with a potential fix here: https://github.com/bchanx/slidr/tree/devel. Could you give that a try and see if there's any progress? |
Brilliant. It works. Needs a bit of work on the CSS but the script works like a charm. Thanks a lot dude. You the man! One last thing, Can we have a resume() function, so we can resume after a stop() call? Or maybe a pause() and resume() function would be better? |
Hey @ahmadux, Are you trying to implement pauseOnHover, or is this for an entirely different usecase? If it's the former, that feature will be added in the next release (in fact, it's already in the devel build you just tested). Otherwise, calling |
Hey. Regards,Usman Ahmadmob:(+974 ) 55142382 Date: Mon, 10 Feb 2014 03:51:31 -0800 Hey @ahmadux, Are you trying to implement pauseOnHover, or is this for an entirely different usecase? If it's the former, that feature will be added in the next release (in fact, it's already in the devel build you just tested). Otherwise, calling .auto() again after you .stop() will resume the slidr as you were describing. You can also change the speed and direction on the resuming .auto() call if you'd like. e.g. .auto(2000, 'left'). — |
Hey @ahmadux, I'll implement it so auto() will reuse the previous input params if you call it a second time. Something like .auto(3000, 'right').stop().auto() will be able to resume the slidr accordingly, and .auto(3000, 'right').stop().auto(2000, 'left') to change directions. I'm not sold on the idea of passing a check function to pause/start, since it complicates the API and I'd like to keep it simple. It's actually possible to implement what you're looking for with the current Slidr API, like so: var s = slidr.create().start();
var timerId = setInterval(function() {
if (condition) s.slide('left/right/up/down');
}, 3000); Which is just a matter of implementing your own timer to conditionally slide. |
The changes to auto() have been implemented and released. Cheers! |
Any plans to support IE 8/9? The script gives an Object Not found at Line 11. Is there a quick fix for it?
The text was updated successfully, but these errors were encountered: