Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file action feature #32

Merged
merged 10 commits into from
Nov 6, 2019
Merged

Conversation

yihou
Copy link
Contributor

@yihou yihou commented Jun 21, 2019

No description provided.

@bchatard
Copy link
Owner

Hi,

Thanks for your contribution. Can you please add a screenshot of the workflow?

@bchatard bchatard self-assigned this Jun 25, 2019
@bchatard bchatard added the enhancement New feature or request label Jun 25, 2019
@yihou
Copy link
Contributor Author

yihou commented Jul 20, 2019

Here you go
jetbrains_file_action mov

src/project.js Outdated Show resolved Hide resolved
src/project.js Outdated Show resolved Hide resolved
const query = alfy.input;

// output
console.log(product.binPath + ' "' + query + '"');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's more clean if we use alfy.output and create an "item". What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but utilising alfy.output actually complicate things,

link output function will nest my only item in an array, which I need to access it through zsh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchatard can you show me the better example?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you output the same format as "standard" workflow, you can reuse the existing run script, no?
If yes, your previous commit with the export of buildItem is a good way to achieve this. And also fix the missing notification.

(a lot of guessing on this, I'm not really available for more debugging on this actually)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agree, currently the Notification does not show proper message. Will get back to this next weekend. Not available at the moment.

@bchatard
Copy link
Owner

bchatard commented Oct 7, 2019

hi @yihou

I made some change on the workflow, that "break" your PR, can you please rebase your branch?

@yihou
Copy link
Contributor Author

yihou commented Oct 14, 2019

sorry for the late reply, I have resolved conflicts and use buildItem to standardise output.

@bchatard
Copy link
Owner

@yihou sorry you will hate me. I made some change (better check on node version and add support to AndroidStudio). Can you update your PR, and then I will merge it

@yihou
Copy link
Contributor Author

yihou commented Nov 6, 2019

Just merged. You may have a look now.

@bchatard bchatard merged commit 341b6da into bchatard:master Nov 6, 2019
@bchatard
Copy link
Owner

bchatard commented Nov 6, 2019

merged ! and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants