Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .NET Standard 2.0. 🚚 #94

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Migrate to .NET Standard 2.0. 🚚 #94

merged 1 commit into from
Aug 25, 2017

Conversation

bchavez
Copy link
Owner

@bchavez bchavez commented Aug 25, 2017

Migration to .NET Standard 2.0.

  • Much cleaner code
  • Got rid of a lot of assembly, csproj project, if-def hacks.

Good job Microsoft.

👈 👇 "Right here, Right now... Right here, Right now..."

@bchavez bchavez merged commit 0c2b0d2 into master Aug 25, 2017
@bchavez bchavez deleted the standard20 branch August 25, 2017 04:43
@Mpdreamz
Copy link
Contributor

Mpdreamz commented Dec 7, 2017

Hey @bchavez any chance of reverting this?

This prevents me from using Bogus in netcoreapp1.1 dotnet core projects. Looking at the diff changeset here looks like its not a burden to keep supporting netstandard1.3

Would love to upgrade to make use of the local seeds 👍

@bchavez
Copy link
Owner Author

bchavez commented Dec 7, 2017

Hey @Mpdreamz. Sounds good. I'll take a look at re-targeting netstandard1.3.

Reference #101

@Mpdreamz
Copy link
Contributor

Mpdreamz commented Dec 7, 2017

🎉 🎈 🍰 thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants