allOf with additional required fields doesn't make them required

[thejuan]

You should be able to specify a reference to a type and a set of required fields using allOf.
At the moment the specified required fields are not required in the typescript (i.e. generated wtih a ? on the property)

{
  type: 'object',
  required: [ 'name', 'location' ],
  additionalProperties: false,
  properties: {
    location: {
      allOf: [
        { $ref: 'location' },
        { required: [ 'postalCode' ] }
      ]
    },
    name: { type: 'string' },
    website: { type: 'string' }
  }
}

In above postalCode should be marked as required, but it's not ATM
https://stackoverflow.com/questions/41958392/extending-ref-with-additional-required-fields

[bcherny]

@handrews @schani Do you know if this is kosher - { required: [ 'postalCode' ] } should make postalCode required in { $ref: 'location' }?

[schani]

Yes, that is correct. This is also a bug in quicktype that I just discovered ;-)

[bcherny]

Related: #96

[thejuan]

I work around this by pre-processing the schemas with
https://github.com/bojand/json-schema-deref
and
https://github.com/mokkabonna/json-schema-merge-allof?files=1