Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Glob 10 #592

Closed
wants to merge 2 commits into from
Closed

Update to Glob 10 #592

wants to merge 2 commits into from

Conversation

evert
Copy link

@evert evert commented Apr 17, 2024 •
edited

We've been dealing with some Typescript issues in our codebase for a while, and tracing everything back I believe upgrading Glob should fix this.

Unfortunately I had some build issues that I didn't fully understand and seemed unrelated to this change.

Lmk what I can do get this merged!

Edit: upon some further inspection I this is similar to #590 .

Fixes #587

@evert
Update to Glob 10
c245390 
We've been dealing with some Typescript issues in our codebase for a
while, and tracing everything back I believe upgrading Glob should fix
this.

Unfortunately I had some build issues that I didn't fully understand and
seemed unrelated to this change.

Lmk what I can do get this merged!
@evert
Copy link
Author

evert commented Apr 17, 2024

This PR causes one test to fail:

  ✖ files in (-i), pipe out Did not match snapshot

  files in (-i), pipe out

  Did not match snapshot

  Difference:

    `/* eslint-disable */␊
    /**␊
     * This file was automatically generated by json-schema-to-typescript.␊
     * DO NOT MODIFY IT BY HAND. Instead, modify the source JSONSchema file,␊
     * and run json-schema-to-typescript to regenerate this file.␊
     */␊
    ␊
  - export interface BSchema {␊
  -   x?: string;␊
  -   y: number;␊
  -   [k: string]: unknown;␊
  - }␊
  - /* eslint-disable */␊
  + export interface ASchema {␊
  +   f: string;␊
  +   g?: number;␊
  + }␊
  + /* eslint-disable */␊
    /**␊
     * This file was automatically generated by json-schema-to-typescript.␊
     * DO NOT MODIFY IT BY HAND. Instead, modify the source JSONSchema file,␊
     * and run json-schema-to-typescript to regenerate this file.␊
     */␊
    ␊
  - export interface ASchema {␊
  -   f: string;␊
  -   g?: number;␊
  + export interface BSchema {␊
  +   x?: string;␊
  +   y: number;␊
  +   [k: string]: unknown;␊
    }␊
    `

  › <anonymous> (test/testCLI.ts:107:7)

@evert
Copy link
Author

evert commented Apr 17, 2024

For some reason that test failed because the output came out in a different order. I rebuilt the snapshots, so this should be good to go now!

@bcherny
Copy link
Owner

bcherny commented Apr 20, 2024

Thanks for the contribution! Done in 4f47952, since it needed some other upgrades + test fixes.

@bcherny bcherny closed this Apr 20, 2024
@evert
Copy link
Author

evert commented Apr 20, 2024

Thank you! Can finally remove a bunch of awkward workarounds! 😍

@evert
Copy link
Author

evert commented Apr 20, 2024

You should remove @types/glob too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to glob 10
2 participants
@evert @bcherny