Merge pull request #31 from Bitspark/master

Fix "RangeError: Maximum call stack size exceeded"
bcherny · Mar 2, 2019 · 45fcb1c · 45fcb1c
2 parents 4756e5f + df2f41f
commit 45fcb1c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/noCircularImportsRule.ts b/noCircularImportsRule.ts
@@ -115,6 +115,9 @@ function walk(context: Lint.WalkContext<Options>) {
     if (!node.moduleSpecifier) {
       return
     }
+    if (!ts.isSourceFile(node.parent)) {
+      return
+    }
     const fileName = node.parent.fileName
 
     if (!ts.isStringLiteral(node.moduleSpecifier)) {
@@ -150,8 +153,8 @@ function walk(context: Lint.WalkContext<Options>) {
     for (const imp of Array.from(moduleImport.keys())) {
       const c = getAllCycles(imp, accumulator.concat(moduleName), iterationDepth + 1)
 
-      if (c.length)
-        all.push(...c)
+      for (const cycle of c)
+        all.push(cycle)
     }
 
     return all