New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass only required attributes of LSI's while creating table #198

Merged

bchew merged 3 commits into bchew:master from DilLip-Chowdary-Codes:patch-1

Feb 23, 2023

Contributor

DilLip-Chowdary-Codes commented Feb 14, 2023

Fixes issues in create_table, when table has local secondary indexes


          Pass only required attributes of LSI's while creating table

e6f8e07

Fixes issues in create_table, when table has local secondary indexes

DilLip-Chowdary-Codes mentioned this pull request

LocalSecondaryIndexes #197

Closed

Contributor Author

DilLip-Chowdary-Codes commented Feb 14, 2023

Related Issue #197

bchew reviewed

View reviewed changes

Owner

bchew left a comment

Thanks for the PR @DilLip-Chowdary-Codes! Could you please fix the linting issue (this project uses black) as it's failing CI.

Not required but if you can add a test for this change that would be great too, thanks!


          Apply Black

87da599

Contributor Author

DilLip-Chowdary-Codes commented Feb 20, 2023

@bchew I've applied black, and when I run black --check ., i got below output:

All done! ✨ 🍰 ✨
5 files would be left unchanged.

Owner

bchew commented Feb 22, 2023

@bchew I've applied black, and when I run black --check ., i got below output:
All done! ✨ 🍰 ✨
5 files would be left unchanged.

I've just done a check and CI output is valid, perhaps you might not be running the current version of Black as per what's used by this project (there were some changes when Black got upgraded to v23)? You can install all the dev requirements as per https://github.com/bchew/dynamodump#development


          Apply Black with latest version

fb56e8d

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

bchew linked an issue

that may be closed by this pull request

LocalSecondaryIndexes #197

Closed

bchew approved these changes

View reviewed changes

bchew merged commit 05a4ee2 into bchew:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment