Add billingMode option #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchew
reviewed
Sep 12, 2021
|
Let me check for tests |
|
@bchew is it satisfying ? |
bchew
reviewed
Sep 14, 2021
bashou
force-pushed
the
feat/billing_mode
branch
from
6393c3b
to
7989c30
Compare
bchew
reviewed
Sep 21, 2021
| @@ -9,6 +9,14 @@ python dynamodump/dynamodump.py -m backup -r local -s testRestoredTable --host l | |||
| --accessKey a --secretKey a | |||
| python tests/test.py | |||
|
|
|||
| # Test wildcard restore and backup with PAY_BY_REQUEST BillingMode | |||
There was a problem hiding this comment.
This test does not actually work - it's PAY_PER_REQUEST.
Currently this test script is for local manual testing, thus it did not get run on CI (https://github.com/bchew/dynamodump/blob/master/.github/workflows/test.yml). I'll probably refactor this at some point so local and CI testing shares the same tests.
|
+1 This is a very needed feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As some use PAY_BY_REQUEST billing mode, we need to be able to choose our current setup for selected table to restore (not necessary for backups).
This PR resolve this point.