Gauge artifact remains after a column hit >100%

[doenietzomoeilijk]

There appears to be a drawing bug, and I'm fairly certain it's in the underlying termui package.

When a containers hits >100% CPU usage, the bar will go red, but when it drops below 100% again, there's one red "pixel" stuck on the right. From a cursory glance at termui, I'd say that percentage should have an extra check for "if it's >100, cap it at 100".

Is this something that should be bumped up to termui, or is it something that can be caught in ctop itself?

[titpetric]

I think the underlying issue is that ctop doesn't normalize CPU use based on cores. I.e. if you have 4 cores, your total cpu usage can go up to 400% (...). It should be trivial to divide this reported number by the number of CPU cores available.

This is what illustrates the issue more concisely (not in a gif :)).

[mcampbell]

Over 100% CPU on multicore system is a common thing to see, so I'm not sure that CPU normalization is the right answer here. But can confirm the bug; after going over 100%, a red pixel is stuck.

[titpetric]

@mcampbell for detail view I agree, only the gauge would need to be normalized to a 0-100 scale to not overlap the additional comments. Imho, displaying "144%" is still valid, so this is just a rendering issue.

[mcampbell]

Yes, 100% (normalized =) agree there; apologies if I misunderstood your intent.

[bcicen]

Thanks all for the input; maximum gauge percent(drawn) has been capped as part of the latest release.

Feel free to reopen if the issue persists.