PHP syntax error in Session_memcached_driver.php

[RobinMICHELAT]

CodeIgniter/system/libraries/Session/drivers/Session_memcached_driver.php

Line 308 in b3f7aae

$this->_memcached-get($this->_key_prefix.$id);

Syntax error generates PHP Fatal error : Call to undefined function get() in .../system/libraries/Session/drivers/Session_memcached_driver.php on line 308

Fix :
$this->_memcached->get($this->_key_prefix.$id);

[narfbg]

I could swear I ran the linter on this, so I did again:

$ php -l system/libraries/Session/drivers/Session_memcached_driver.php 
No syntax errors detected in system/libraries/Session/drivers/Session_memcached_driver.php

After a closer look, it probably reads it as $this->_memcached minus get($this->_key_prefix.$id) ... I'm speechless.

[cyoon84]

when will this fix merge to the master?

[jim-parry]

@cyoon84 This has been flagged for 3.1.10, but that does not have a specific release date.

[cyoon84]

so should I downgrade to 3.1.8 for now?

…

On Jun 28, 2018, at 1:34 PM, Instructor, BCIT ***@***.***> wrote: @cyoon84 <https://github.com/cyoon84> This has been flagged for 3.1.10, but that does not have a specific release date. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5526 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABrLHbGTuCoFxbhzPFqygZwd9HABtOctks5uBROsgaJpZM4Ungvu>.

[jim-parry]

@cyoon84 You could always make the change manually in your Session_memcached_driver, which would then be over-written by the next release. Not normally a recommended practice, but it seems to fit in this case.