Fixed libraries/Email.php: UTF8 subject line encoding for Apple Mail (and iOS Mail) / WordWrap for plaintext email #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… $config['wrapchars'] settings so that even the plaintext of a multipart email will follow the wordwrap parameters in the email config file.
…ing as Apple Mail (and iOS Mail) have problems loading many of the UTF-8 subject lines when they are encoded with Q encoding (_prep_q_encoding)
| $this->_set_header('Subject', $subject); | ||
| { | ||
| $subject = '=?UTF-8?B?'.base64_encode($subject).'?='; | ||
| parent::_set_header('Subject', $subject); |
There was a problem hiding this comment.
CI_Email doesn't have a parent class - this would probably trigger a fatal error.
Also, use tabs for indentation instead of spaces. See the coding style guidelines for more info.
There was a problem hiding this comment.
oops sorry, I copied the code over from MY_Email class last night where I was doing all the testing.
|
I have fixed the error and shortened the code as suggested by @narfbg |
|
Both issues resolved and hopefully I won't forget to look at the multibyte characters issue. |
|
if the encoding is known, could use multibyte functions like mb_strcut() or mb_split() |
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the Email.php library so that UTF8 subject lines (currently encoded with Q encoding) will show up correctly in Apple Mail / iOS Mail (using B encoding instead).
It also patches the _get_alt_message function so that emails sent from CI will honor the $config['wordwrap'] and $config['wrapchars'] settings.
PS: The word_wrap function used in the master source code does not work well with multibyte characters. It wraps multibyte characters in the middle and breaks multibyte characters making them look like random symbol. This led me to try and disable wordwrap in config only to find out wordwrap wasn't honored in the existing source.