Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest of the helpers #1300

Merged
merged 7 commits into from May 17, 2012
Merged

Fix rest of the helpers #1300

merged 7 commits into from May 17, 2012

Conversation

timw4mail
Copy link
Contributor

Also removes deprecated function js_insert_smiley

@narfbg
Copy link
Contributor

narfbg commented May 17, 2012

'string' instead of 'str' and add a changelog entry about js_insert_smiley().

*
* @param string the URL to the folder containing the smiley images
* @param array
* @param array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird compared to the one above it (use tabs instead of spaces, if you didn't).

@narfbg
Copy link
Contributor

narfbg commented May 17, 2012

That should be all - poke me when you finish it as commits don't send notifications.

@timw4mail
Copy link
Contributor Author

@narfbg There you go.

narfbg added a commit that referenced this pull request May 17, 2012
@narfbg narfbg merged commit e30b3f7 into bcit-ci:develop May 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants