Feature/stringify attributes #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes through out various helpers. Signed-off-by: Eric Barnes <eric@ericlbarnes.com>
Signed-off-by: Eric Barnes <eric@ericlbarnes.com>
Feature/stringify attributes
Not sure how to revert this. Signed-off-by: Eric Barnes <eric@ericlbarnes.com>
|
Looks good to me Eric :) |
ericlbarnes
added a commit
that referenced
this pull request
Jul 29, 2012
Feature/stringify attributes
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
…butes Feature/stringify attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull is to add the attributes mentioned in #1664
Also added a new _stringify_attributes function in common and refactored all the places that used duplicate code to instead use this.
Sending a pull just for a second pair of eyes. But should be solid and phpunit is showing 100% test coverage of the function and all tests still passing.