Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader fixes and improvements #1769

Closed
wants to merge 5 commits into from
Closed

Loader fixes and improvements #1769

wants to merge 5 commits into from

Commits on Sep 4, 2012

  1. No need to track loaded files. 

    PHP already tracks all included files, through the mechanisms employed by the *_once include/require methods. The collection of all included files can be retrieved through get_included_files().
Removed the local property _ci_loaded_files and the implementations where newly included files are added to the collection.
Replaced the enquiring of included files with the built in PHP functionality.
    @nickl-
    nickl- committed Sep 4, 2012
    Copy the full SHA
    b9effd0 View commit details
    Browse the repository at this point in the history

  2. Unit tests load and subclass Session #353. 

    Unit tests to reproduce the problem raised in #353.
In addition to testing load by libary or load by driver we are also extending by prefixed sub-class.
Added new mack application folder.
Added Session Subclass mock.
Fix bootstrap to point APPPATH to the mock application folder.
Including IC_Session class more than once in the same unit test requires runInSeparateProcess and preserveGlobalState disabled
which also causes all knowledge of bootstrap to dissapear so we need to cater for that.
    @nickl-
    nickl- committed Sep 4, 2012
    Copy the full SHA
    7102c63 View commit details
    Browse the repository at this point in the history

  3. Suppress headers already sent warnings.

    @nickl-
    nickl- committed Sep 4, 2012
    Copy the full SHA
    63bf687 View commit details
    Browse the repository at this point in the history

  4. Fix #353 Prefixed subclass Session extended. 

    Support for case sensitive FS
Allows for extended class to be in library or library/Session folders.
Solves problems extending Session as identified in #353.
    @nickl-
    nickl- committed Sep 4, 2012
    Copy the full SHA
    22e3549 View commit details
    Browse the repository at this point in the history

  5. Fix #353 Allow Session extend with or without driver. 

    To extend the Session and drivers you would add same named drivers to the valid_drivers collection.
This allows you to still fall back to the standard session drivers eves thaugh we extended CI_Session.
Also helps solving problems discovered in #353.
    @nickl-
    nickl- committed Sep 4, 2012
    Copy the full SHA
    898805b View commit details
    Browse the repository at this point in the history