Updated CI Security unit test #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Heesung Ahn <ahn.heesung@gmail.com>
Signed-off-by:Heesung Ahn <ahn.heesung@gmail.com>
|
|
||
| // -------------------------------------------------------------------- | ||
|
|
||
| public function test_xss_clean_image_invalid() |
There was a problem hiding this comment.
Looks like you've used spaces for indentation for everything but the curly braces.
Can you convert those to tabs? That's what we use for indentation, it's explained in our styleguide.
There was a problem hiding this comment.
It is now using tabs not spaces.
Signed-off-by:Heesung Ahn <ahn.heesung@gmail.com>
narfbg
added a commit
that referenced
this pull request
Mar 10, 2015
Improve CI_Security unit tests coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Code Coverage from 54.55% to 77.27% for CI_Security.