Changes to stored_procedure with oracle #3704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a trouble with the stored procedure, first the function was strict with the package name, with this implementation the package is optional, and the second is that the bind_by_name was failt, because it was assigning two ids of connection, one time at binding and other when the query excecute.
narfbg
added a commit
that referenced
this pull request
Jul 17, 2015
|
I just pushed a bugfix for the binding bug (you can see the commit linked above). Yours was based on CI2 and because of that, it actually made more breaks. However, the package parameter is a larger issue than it seems and allowing an empty string to be passed would be a band-aid on a bullet wound. See #3981 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a trouble with the stored procedure, first the function was
strict with the package name, with this implementation the package is
optional, and the second is that the bind_by_name was failt, because it
was assigning two ids of connection, one time at binding and other when
the query excecute.