Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to pull config fields out of post data #4127

Closed
wants to merge 2 commits into from

Conversation

zoaked
Copy link
Contributor

@zoaked zoaked commented Sep 20, 2015

#2436 - Created a PR for this very useful feature. In short it only pulls fields out of post data that also have a validation configuration.

@jim-parry
Copy link
Contributor

Good idea. This should also have a changelog entry & update for the user guide, if it is to go ahead.

@narfbg
Copy link
Contributor

narfbg commented Sep 21, 2015

What if the validated data isn't in $_POST?

@zoaked
Copy link
Contributor Author

zoaked commented Sep 22, 2015

Is posting code in an issue considered to be providing it to the project? I did not create this method and am wondering if the original author posting it to the above issue means it is being made available or not? In my opinion it seems like it does, but I want to also make sure that all your project policies are being followed.

@narfbg
Copy link
Contributor

narfbg commented Sep 23, 2015

It is, but if you're just submitting a patch that was already provided (in whatever form) by another issue and we haven't applied it, it means we didn't like it in the first place.
One of the reasons why is the questions I asked above, which you didn't answer.

Closing here; you can discuss it in #2436 if you want to.

@narfbg narfbg closed this Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants