encodefromlegacy patch #4267
Closed
encodefromlegacy patch #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the encode_from_legacy method as it didn't decode properly. The mcrypt_decode method has changed from the 1.x version. This update include legacy methods for decode and mcrypt_decode. They are declare private. Also added public/private to all methods and updated some PHPDoc
Update Encrypt.php
|
CI2 is no longer supported, sorry. |
|
Sure, but people might still want to migrate from older version and they'll run into the same issue as I did when upgrading an old project from 1.7 to 2.2.6, before updating to 3.x. Perhaps you can merge it into the 3.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the encode_from_legacy method as it didn't decode properly. The mcrypt_decode method has changed from the 1.x version.
This update includes legacy methods for decode and mcrypt_decode. They are declare private.
Also added public/private to all methods and updated some PHPDoc