Bugfix: DB_query_builder order_by / count_all_results #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for $this->qb_orderby = $this->qb_cache_orderby should be an empty array. Setting it to NULL causes an error on line 1238 when trying to merge it with new values.
webwerken
changed the title
|
OK. Missed that one. Glad is was already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default type for $this->qb_orderby and $this->qb_cache_orderby is an empty array.
Setting it to NULL in method 'count_all_results' causes an error on line 1238 when trying to merge it with newly added values.
The other option to prevent this would be to check before merging or to typecast.