Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/html5 #743

Closed
wants to merge 3 commits into from
Closed

Feature/html5 #743

wants to merge 3 commits into from

Conversation

tobz-nz
Copy link

@tobz-nz tobz-nz commented Dec 6, 2011

Added html5 datalist to form helper.

* @param array $options
* @param mixed $attributes
*/
if ( ! function_exists('form_datalist')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces need to be placed on separate lines, like you've done with the if()s.

@AkenRoberts
Copy link
Contributor

Anyone else have a small issue with adding support for HTML5 elements, which are not an official spec yet and subject to changes? Data lists aren't even supported in Chrome yet, let alone IE and older versions of FF and Opera.

@tobz-nz Paging pull request author! Can we do something about getting this optimized and up-to-date with the current 3.0 repo?

@ragingdave
Copy link
Contributor

Hey was going to start pushing some updates for this issue in a new pull request, was wondering how to go about pulling in the latest dev changes into the feature branch, or instead, just re-create a feature from a new set of pull requests based off dev?

ragingdave added a commit to ragingdave/CodeIgniter that referenced this pull request Sep 26, 2013
updated changelog.rst
updated form_helper.rst
added currently merged features
cleaned up code a bit
@narfbg
Copy link
Contributor

narfbg commented Jan 24, 2014

@DaveMC08

I don't really understand your question, but pulling changes in is as simple as:

git pull git@github.com:EllisLab/CodeIgniter.git <branch>

Closing this PR now ... old, questionable, no response from the author ...

@narfbg narfbg closed this Jan 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants